Skip to content

Conversation

christinalau0
Copy link
Contributor

Reason for Change:

Previously, deploying mixed clusters (linux + windows nodes) with azuredisk-csi-driver addon hit custom data too long error:
Custom data in OSProfile must be in Base64 encoding and with a maximum length of 87380 characters.

  • This PR shortens variable names in cloud init scripts, reducing custom data length.
  • ci: Test suites previously set EnableTelemetry to true by default, which caused the CSE to be longer. This PR sets EnableTelemetry to false by default.
  • ci: Fix featureflag nil pointers now that the EnableTelemetry feature flag is no longer set by default.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@christinalau0 christinalau0 requested a review from jadarsie March 30, 2023 17:18
@christinalau0
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jadarsie jadarsie merged commit b060023 into Azure:master Mar 30, 2023
@christinalau0 christinalau0 deleted the shorten-cloud-init branch March 30, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants