Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

install blobfuse & smb flexvol drivers in provision time #3455

Merged
merged 3 commits into from
Jul 17, 2018
Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

Conversation

andyzhangx
Copy link
Contributor

@andyzhangx andyzhangx commented Jul 10, 2018

What this PR does / why we need it:
install blobfuse & smb flexvol drivers in provision time

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

install blobfuse & smb flexvol drivers in provision time

@jackfrancis
FYI @khenidak @seguler

@codecov
Copy link

codecov bot commented Jul 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4b9c004). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3455   +/-   ##
=========================================
  Coverage          ?   55.95%           
=========================================
  Files             ?      105           
  Lines             ?    15919           
  Branches          ?        0           
=========================================
  Hits              ?     8907           
  Misses            ?     6262           
  Partials          ?      750

@andyzhangx andyzhangx changed the title install blobfuse flexvol driver in provision time install blobfuse & smb flexvol drivers in provision time Jul 12, 2018
@andyzhangx andyzhangx force-pushed the install-blobfuse-flexvol branch from ef47ca0 to 40616ea Compare July 12, 2018 06:31
@andyzhangx
Copy link
Contributor Author

@jackfrancis PTAL, this is a milestone feature for blobfuse flexvol driver, eventually it's built-in

@ghost ghost assigned jackfrancis Jul 17, 2018
@ghost ghost added the in progress label Jul 17, 2018
@andyzhangx
Copy link
Contributor Author

Woo! @jackfrancis Fantastic!

@jackfrancis jackfrancis force-pushed the install-blobfuse-flexvol branch from 79581ea to 0c4dad3 Compare July 17, 2018 16:18
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis
Copy link
Member

jackfrancis commented Jul 17, 2018

@andyzhangx I'm (manually) mirroring the two files in CDN. Here are my notes for maintaining this over time:

	- Update flexvol drivers
		○ Check https://github.com/Azure/kubernetes-volume-drivers/releases for new releases
		○ Actual files are (using v0.1 as an example):
			§ https://raw.githubusercontent.com/Azure/kubernetes-volume-drivers/v0.1/flexvolume/blobfuse/deployment/blobfuse-flexvol-installer/blobfuse
			§ https://raw.githubusercontent.com/Azure/kubernetes-volume-drivers/v0.1/flexvolume/smb/deployment/smb-flexvol-installer/smb
		○ Update acs-mirror w/ new files, then update CSE references
			§ E.g., https://acs-mirror.azureedge.net/flexvol/blobfuse-v0.1
			§ E.g., https://acs-mirror.azureedge.net/flexvol/smb-v0.1

andyzhangx and others added 3 commits July 17, 2018 11:35
revert bindata.go

install smb flexvolume driver

add cifs-utils package for smb flexvolume driver
@jackfrancis jackfrancis force-pushed the install-blobfuse-flexvol branch from bd3a7aa to d4a7852 Compare July 17, 2018 19:03
@jackfrancis jackfrancis merged commit 7cf1887 into Azure:master Jul 17, 2018
kkmsft pushed a commit to kkmsft/acs-engine that referenced this pull request Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants