Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding FSI architecture definition template #58

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat: adding FSI architecture definition template #58

merged 1 commit into from
Nov 12, 2024

Conversation

sdeguchi
Copy link
Collaborator

@sdeguchi sdeguchi commented Nov 11, 2024 •
edited
Loading

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Adds FSI architecture definition template

Breaking Changes

  1. None

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@sdeguchi sdeguchi changed the title Adding FSI architecture definition template feat: adding FSI architecture definition template Nov 12, 2024
@sdeguchi sdeguchi requested review from jaredfholgate and a team and removed request for jaredfholgate and a team November 12, 2024 02:46
@jaredfholgate jaredfholgate self-assigned this Nov 12, 2024
jaredfholgate
jaredfholgate approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaredfholgate
jaredfholgate reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not added to e2e tests. Can raise a separate PR for this or add to this one.

@jaredfholgate jaredfholgate merged commit efcfe9c into Azure:main Nov 12, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredfholgate jaredfholgate jaredfholgate approved these changes

Assignees

@jaredfholgate jaredfholgate

Labels
Needs: Triage 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdeguchi @jaredfholgate