Skip to content

Add binary request body #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Add binary request body #486

wants to merge 4 commits into from

Conversation

AllyW
Copy link
Contributor

@AllyW AllyW commented May 29, 2025

Binary request example:

{
            "name": "body",
            "in": "body",
            "description": "The file content as application/octet-stream.",
            "required": true,
            "schema": {
              "type": "string",
              "format": "binary"
            }
 }

from loadtestservice: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/loadtestservice/data-plane/Microsoft.LoadTestService/preview/2024-12-01-preview/loadtestservice.json#L2155-L2164

@AllyW AllyW marked this pull request as ready for review June 4, 2025 02:29
kairu-ms
kairu-ms reviewed Jun 4, 2025
View reviewed changes
src/aaz_dev/cli/controller/az_arg_group_generator.py
elif isinstance(arg, CMDByteArgBase):
raise NotImplementedError()
elif isinstance(arg, CMDBinaryArgBase):
arg_type = "AAZFileUploadArg"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it names AAZFileUploadArg? Maybe directly use the AAZFileArg as the name

kairu-ms
kairu-ms reviewed Jun 4, 2025
View reviewed changes
src/aaz_dev/cli/controller/az_arg_group_generator.py
Comment on lines -350 to -353
elif isinstance(arg, CMDByteArgBase):
raise NotImplementedError()
elif isinstance(arg, CMDBinaryArgBase):
raise NotImplementedError()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to move it out of the string arg? I think it should be part of the string arg right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kairu-ms kairu-ms kairu-ms left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AllyW @kairu-ms