Skip to content

[Modules] Added CMK to Net-App module & updated API version #3577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

[Modules] Added CMK to Net-App module & updated API version #3577

wants to merge 11 commits into from

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Aug 14, 2023 •
edited
Loading

Description

  • Added suport for CMK
  • Added support for volumne encryption (default would be 'Single')

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
NetApp - NetAppAccounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner August 14, 2023 22:30
@AlexanderSehr AlexanderSehr linked an issue Aug 14, 2023 that may be closed by this pull request
[Failed pipeline] NetApp - NetAppAccounts #3539
Closed
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Aug 14, 2023
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) August 26, 2023 10:06
eriqua
eriqua reviewed Aug 26, 2023
View reviewed changes
@AlexanderSehr AlexanderSehr requested a review from eriqua August 26, 2023 19:45
@AlexanderSehr
Copy link
Contributor Author

AlexanderSehr commented Aug 26, 2023 •
edited
Loading

Moving to draft due to 'Preview Feature' status.

@AlexanderSehr AlexanderSehr marked this pull request as draft August 26, 2023 20:07
auto-merge was automatically disabled August 26, 2023 20:07

Pull request was converted to draft

@ahmadabdalla ahmadabdalla linked an issue Aug 26, 2023 that may be closed by this pull request
[Feature Request]: Extend Azure NetApp Files module with CMK #2991
Open
@ahmadabdalla
Copy link
Contributor

@AlexanderSehr ==> added this as a reference issue ==> #2991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua Awaiting requested review from eriqua

At least 1 approving review is required to merge this pull request.

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Extend Azure NetApp Files module with CMK [Failed pipeline] NetApp - NetAppAccounts
3 participants
@AlexanderSehr @ahmadabdalla @eriqua