Skip to content

Conversation

@paulinek13
Copy link
Contributor

@paulinek13 paulinek13 commented Jun 16, 2025

Description

Related: #653

The goal of this PR is to improve the API reference for prompt_converter module (since there are a number of gaps in this list),
and to make sure that the docstrings are formatted properly:
image

Tests and Documentation

Basically the docs update, no tests modified.

Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah you did so many 🔥 nice work

@romanlutz
Copy link
Contributor

I think you'll find that the website generation doesn't like things like

some level of indentation
  - a deeper level of indentation

in the API reference. It's unclear to me why but somehow that doesn't work. At some point in the future I want to switch to JupyterBook2 and MyST instead of all these sphinx extensions like autodoc but as I discovered last night that day is not today (because they don't support API reference generation yet).

@romanlutz romanlutz self-assigned this Jun 17, 2025
@paulinek13
Copy link
Contributor Author

@romanlutz

I think you'll find that the website generation doesn't like things like

some level of indentation
  - a deeper level of indentation

in the API reference. It's unclear to me why but somehow that doesn't work.

It seems that there must be a new blank line before a list.
As an example:

image
results in Unexpected indentation error and visually it's not what it should be;

image
but this is 100% fine: no errors and proper formatting on the page.

@romanlutz
Copy link
Contributor

Great! Then please ignore me and proceed 🤣

@paulinek13 paulinek13 changed the title [DRAFT] DOC: improve API reference for prompt_converter DOC: improve API reference for prompt_converter module Jun 17, 2025
@paulinek13 paulinek13 marked this pull request as ready for review June 17, 2025 15:25
@paulinek13 paulinek13 force-pushed the docs/update_prompt_converter_api branch from 3adf402 to af0316a Compare June 17, 2025 21:51
@romanlutz romanlutz merged commit 5e84fac into Azure:main Jun 24, 2025
20 checks passed
Sarayu-code pushed a commit to Sarayu-code/PyRIT that referenced this pull request Jul 11, 2025
@paulinek13 paulinek13 deleted the docs/update_prompt_converter_api branch November 6, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants