[DRAFT] FEAT Dataset Loading Utilities #1201
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
reviewed
Nov 22, 2025
| return seed_prompts | ||
|
|
||
| @classmethod | ||
| def get_seed_dataset(cls, which: str) -> SeedDataset: |
Contributor
There was a problem hiding this comment.
Which is not a common parameter naming choice. Name seems preferable.
| """ | ||
| @classmethod | ||
| def seed_dataset_to_list_str(cls, dataset: Path) -> List[str]: | ||
| seed_prompts: List[str] = [] |
Contributor
There was a problem hiding this comment.
I'm kind of surprised we're using these as plain strings. It loses all the metadata. That means we lose harm categories, for example. How will one query for the results?
rlundeen2
reviewed
Dec 2, 2025
| from pyrit.common.path import DATASETS_PATH, SCORER_CONFIG_PATH | ||
| from pyrit.datasets.harmbench_dataset import fetch_harmbench_dataset | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
This is a good stab at the problem. But I think the route I prefer to go is to make everything really easy to put in the database (e.g. include initializer that load all the scenario datasets) and then just have the scenarios grab from the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
pyrit.scenario.datasetandpyrit.scenario.dataset.ScenarioDatasetUtilsto compartmentalize common dataset loading patterns for Scenarios.Tests and Documentation
IP