-
Notifications
You must be signed in to change notification settings - Fork 544
Align SeedPrompt with PromptRequestPiece #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hannahwestra25
merged 17 commits into
Azure:main
from
hannahwestra25:hawestra/seedprompt_unification
Aug 12, 2025
Merged
Align SeedPrompt with PromptRequestPiece #1053
hannahwestra25
merged 17 commits into
Azure:main
from
hannahwestra25:hawestra/seedprompt_unification
Aug 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eedprompt_unification
…eedprompt_unification
rlundeen2
reviewed
Aug 8, 2025
rlundeen2
reviewed
Aug 8, 2025
rlundeen2
reviewed
Aug 8, 2025
jsong468
reviewed
Aug 8, 2025
rlundeen2
reviewed
Aug 8, 2025
rlundeen2
approved these changes
Aug 8, 2025
jsong468
reviewed
Aug 8, 2025
jsong468
reviewed
Aug 8, 2025
jsong468
reviewed
Aug 8, 2025
jsong468
reviewed
Aug 8, 2025
jsong468
reviewed
Aug 8, 2025
jsong468
reviewed
Aug 9, 2025
jsong468
approved these changes
Aug 11, 2025
…hannahwestra25/PyRIT into hawestra/seedprompt_unification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: Use of sequence in SeedPrompt was unclear and SeedPrompts did not support roles. Sequence in SeedPrompt and PromptRequestPiece should mean the same thing.
PromptRequestResponse: This is a single request to a target. It can contain multiple prompt request pieces. Within a PromptRequestResponse, PromptRequestPieces must share:
SeedPromptGroup: A group of prompts that need to be sent together. It can contain multiple SeedPrompts. Each SeedPromptGroup will share:
Sequence: The turn in a conversation; will be the same with prompts that are sent together (i.e. an image and text)
SeedPrompts can be associated together using the sequence number. If two (or more) SeedPrompts share both a prompt_group_alias (ie a prompt_group_id meaning they are apart of the same SeedPromptGroup) AND the same sequence number, the SeedPrompts are associated and are sent in the order the sequence specifies.
PromptRequestPieces will be associated together using the sequence number. PromptRequestPieces with the same sequence can be associated via a PromptRequestResponse (which requires that all PromptRequestPieces share the same sequence). The sequence then specifies which order PromptRequestResponse will be sent in the conversation.
Both SeedPrompts with the same sequence which are in the same SeedPromptGroup and PromptRequestPieces with the same sequence which are in the same conversation must share a role.
This PR adds the role to SeedPrompt and enforces that SeedPrompts in a SeedPromptGroup that have the same sequence also have the same role. Additionally, move SeedPromptGroup and SeedPromptDataset to their own files.
Tests and Documentation
Added a few tests and updated the prompt datasets we have