Fix tutorial 2 #59
Closed
Fix tutorial 2 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value returned by service.run is a JSON thus it must be deserialized. Otherwise, we compare the predicted classes to the characters of a JSON string.
Contributor
|
Good catch, but the issue is further upstream. Please see #60 for fix. I'm closing this PR. |
Author
|
OK nice! Should the snippets in the doc be changed to match the changes in the notebook? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The commit 114449d breaks the comparison between the true classes and the classes predicted by the deployed service at the end of tutorial 2.
The value returned by service.run is a JSON thus it must be deserialized. Otherwise, we compare the predicted classes to the characters of a JSON string.