Skip to content

Conversation

@dem108
Copy link

@dem108 dem108 commented Oct 17, 2018

Basically current local_run.register_model() fails as it does not specify which iteration to register.
To fix this, first, I've set the exit_score to 0.9995. This allows we see all 20 interations.
Then, I added description that iteration=9 is the best model, confirmed from Widget.
Lastly, I've added iteration=9 as a parameter to register_model() call. This ensures successful registration of the model.

Basically current local_run.register_model() fails as it does not specify which iteration to register. 
To fix this, first, I've set the exit_score to 0.9995. This allows we see all 20 interations.
Then, I added description that iteration=9 is the best model, confirmed from Widget.
Lastly, I've added iteration=0 as a parameter to register_model() call. This ensures successful registration of the model.
@rastala rastala requested a review from jeff-shepherd October 18, 2018 16:54
@jeff-shepherd
Copy link
Contributor

Thanks for suggesting this. It is usually good to run more iterations.
However, this is a tutorial and we want it to execute quickly. So, I would like to keep the exit_score as it is. Also, register_model without the iteration parameter automatically selects the best model, which is a more common pattern. I tested the current released build and it is working.

@dem108
Copy link
Author

dem108 commented Oct 19, 2018

Hi, I've re-checked and tried the original one. Yes, it worked without issues. That could have been some temporary issue for me back then. Sorry for confusion. I will close this.

@dem108 dem108 closed this Oct 19, 2018
@dem108 dem108 deleted the patch-1 branch October 19, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants