Skip to content

fix(designer): Add property check for content in inputs/outputs object #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix(designer): Add property check for content in inputs/outputs object #3225

merged 1 commit into from
Aug 30, 2023

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Aug 30, 2023 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fixes In China regions, new designer is not able to show trigger input and output #3213

  • What is the current behavior? (You can also link to an open issue here)
    Rendering of the inputs/outputs was failing because of a null property error

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Please Include Screenshots or Videos of the intended change:

Screenshot 2023-08-30 at 3 32 29 PM

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for celadon-tartufo-aaf61b ready!

Name Link
🔨 Latest commit ce6a6ca
🔍 Latest deploy log https://app.netlify.com/sites/celadon-tartufo-aaf61b/deploys/64efc602caa89b00084ee993
😎 Deploy Preview https://deploy-preview-3225--celadon-tartufo-aaf61b.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ccastrotrejo ccastrotrejo marked this pull request as ready for review August 30, 2023 22:43
@ccastrotrejo ccastrotrejo enabled auto-merge (squash) August 30, 2023 22:47
@Eric-B-Wu
Copy link
Contributor

do you know if this is the same issue as: #3140?

@ccastrotrejo
Copy link
Contributor Author

do you know if this is the same issue as: #3140?

It looks really similar, I can try to repro the scenario. If any of the properties that are returned in the outputs/inputs are undefined or null, definitely its the same

@ccastrotrejo ccastrotrejo merged commit 263b8f0 into main Aug 30, 2023
@ccastrotrejo ccastrotrejo deleted the ccastrotrejo/OutputsFix branch August 30, 2023 23:32
ccastrotrejo added a commit that referenced this pull request Aug 30, 2023
@ccastrotrejo
fix(designer): Add property check for content in inputs/outputs object (
a5a548a 
#3225)

Add property check for content in inputs/outputs object
ccastrotrejo added a commit that referenced this pull request Aug 31, 2023
@ccastrotrejo
fix(designer): Add property check for content in inputs/outputs object (
4aa4edf 
#3226)

fix(designer): Add property check for content in inputs/outputs object (#3225)

Add property check for content in inputs/outputs object
@ccastrotrejo ccastrotrejo mentioned this pull request Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-B-Wu Eric-B-Wu Eric-B-Wu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In China regions, new designer is not able to show trigger input and output
2 participants
@ccastrotrejo @Eric-B-Wu