Fix sessions in Twin are not closed when endpoint is deactivated. #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcschier
changed the title
cristipogacean
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a regression, the keep alive is counted towards the session's activity state, and any cleanup of it through the collector timer is not happening while keepalive's are being sent (constantly) because the timeout value (1 minute) is much larger than the keep alive timer duration (5 seconds). Also keep alive operations in progress are counted towards the session being active.
Change to only count operations other than keep alive towards "active" state of the session. This has limited risk due to the fact that a reference count is being held by the twin keeping the session active despite its activity state. Once the reference count is released, we want the session GC to kick in and collect the "inactive" session.