Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publisher 2.5.6, fix for ICM ticket, refactor config and latest Nuget packages. #1505

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Publisher 2.5.6, fix for ICM ticket, refactor config and latest Nuget packages. #1505

merged 1 commit into from
Dec 21, 2021

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Dec 20, 2021 •
edited
Loading

  • bump up to use latest OPCF Nuget packages.
  • fix issue that a new certificate on windows can not be used due to missing key set.
  • refactor UA app config to use the OPCF config API instead of legacy init code, which caused issues with certs on .NET Core 3.1 and above.
  • improve logging, to output at least error and security at info level.

@mregen mregen requested a review from a team as a code owner December 20, 2021 08:32
@lgtm-com
Copy link

lgtm-com bot commented Dec 20, 2021

This pull request fixes 3 alerts when merging 7820ddb into 7a2111f - view on LGTM.com

fixed alerts:

  • 1 for Constant condition
  • 1 for Call to obsolete method
  • 1 for Dereferenced variable may be null

@mregen mregen merged commit 216b5b1 into release/2.5 Dec 21, 2021
@mregen mregen deleted the proto2.5.6 branch December 21, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcschier marcschier marcschier approved these changes

@cristipogacean cristipogacean cristipogacean approved these changes

Assignees

@mregen mregen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mregen @marcschier @cristipogacean