Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portal accelerator updates #1342

Merged
merged 38 commits into from
Jun 12, 2023
Merged

Portal accelerator updates #1342

merged 38 commits into from
Jun 12, 2023

Conversation

Springstone
Copy link
Member

@Springstone Springstone commented May 31, 2023 •
edited
Loading

Overview/Summary

Updating Portal Accelerator tooltips to include links to applied policies or initiatives. Fixed the SQL TDE assignment, and added a SQL Threat Protection radio using what was originally assigned.

This PR fixes/adds/changes/removes

  1. Portal Accelerator UI updates
  2. Fixed SQL TDE assignment - in the original DINE-SQLEncryptionPolicyAssignment
  3. Add new SQL Threat Detection assignment - new file DINE-SQLThreatPolicyAssignment
  4. Disable the automatic assignment of Deploy-LogAnalytics

Breaking Changes

  1. N/A

Testing Evidence

image

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@Springstone Springstone requested a review from a team as a code owner May 31, 2023 16:10
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 31, 2023
@Springstone Springstone added enhancement New feature or request policy and removed Needs: Triage 🔍 Needs triaging by the team labels May 31, 2023
@Springstone Springstone temporarily deployed to csu-rw May 31, 2023 16:26 — with GitHub Actions Inactive
@Springstone Springstone added this to the policy-refresh-fy23-q4 milestone Jun 6, 2023
@Springstone Springstone requested a review from jtracey93 June 6, 2023 18:36
@Springstone Springstone temporarily deployed to csu-rw June 7, 2023 12:22 — with GitHub Actions Inactive
jtracey93
jtracey93 requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few bits

@ghost ghost removed the Needs: Author Feedback label Jun 7, 2023
@Springstone Springstone temporarily deployed to csu-rw June 7, 2023 18:56 — with GitHub Actions Inactive
@Springstone
Copy link
Member Author

@jtracey93 good to review.

@jtracey93 jtracey93 merged commit c273ebf into Azure:policy-refresh-q4fy23 Jun 12, 2023
@Springstone Springstone deleted the PortalAcceleratorUpdates branch June 13, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request policy
Projects
None yet
Milestone
policy-refresh-fy23-q4
Development

Successfully merging this pull request may close these issues.
2 participants
@Springstone @jtracey93