Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for User Stories 28607-28609-28620 #1339

Merged
merged 17 commits into from
Jun 13, 2023
Merged

PR for User Stories 28607-28609-28620 #1339

merged 17 commits into from
Jun 13, 2023

Conversation

pkorolo
Copy link
Contributor

@pkorolo pkorolo commented May 30, 2023

Overview/Summary

PR for User Stories 28609 and 28620

This PR fixes/adds/changes/removes

  1. adds custom policy for 'Storage Accounts with SFTP enabled should be denied'
  2. adds custom policy for 'Subnets without Private Endpoint Network Policies enabled should be denied'

Breaking Changes

  1. None known

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Testing URLs

The below URLs can be updated where the placeholders are, look for {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also} & {YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}, to allow you to test your portal deployment experience.

Please also replace the curly brackets on the placeholders {}

Azure Public

[Deploy To Azure](https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Feslz-portal.json)

Azure US Gov (Fairfax)

[Deploy To Azure](https://portal.azure.us/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Ffairfaxeslz-portal.json)

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 30, 2023
@pkorolo
Copy link
Contributor Author

pkorolo commented May 31, 2023

Tests & evidence:

image

image

image

image

image

@pkorolo pkorolo marked this pull request as ready for review May 31, 2023 10:50
@pkorolo pkorolo temporarily deployed to csu-rw May 31, 2023 10:51 — with GitHub Actions Inactive
@pkorolo
Copy link
Contributor Author

pkorolo commented Jun 2, 2023

converting this to draft again, to add user story 28607

@pkorolo pkorolo marked this pull request as draft June 2, 2023 06:05
@pkorolo pkorolo changed the title PR for User Stories 28609 and 28620 PR for User Stories 28607-28609-28620 Jun 2, 2023
@pkorolo
Copy link
Contributor Author

pkorolo commented Jun 2, 2023

Test and evidence for the third custom policy addition:

image

image

image

image

image

image

image

@pkorolo
Copy link
Contributor Author

pkorolo commented Jun 2, 2023

All code for the three (3) User Stories included, please review.

@pkorolo pkorolo marked this pull request as ready for review June 2, 2023 15:38
@pkorolo pkorolo requested a review from a team as a code owner June 2, 2023 15:39
@pkorolo pkorolo temporarily deployed to csu-rw June 2, 2023 15:39 — with GitHub Actions Inactive
@jtracey93 jtracey93 requested a review from Springstone June 7, 2023 17:29
Copy link
Member

@Springstone Springstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pkorolo, one small change for the What's New section, and can you please resolve the merge conflict.

@pkorolo pkorolo marked this pull request as draft June 13, 2023 16:18
@pkorolo pkorolo marked this pull request as ready for review June 13, 2023 16:35
@Springstone Springstone temporarily deployed to csu-rw June 13, 2023 17:00 — with GitHub Actions Inactive
@Springstone Springstone merged commit 973126f into Azure:policy-refresh-q4fy23 Jun 13, 2023
@pkorolo pkorolo deleted the pkb1-policy-refresh-q4fy23 branch June 13, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants