Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ArmApiControl path to get VNetGW on the selected VNet Subscrition #342

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

vivalada
Copy link
Contributor

@vivalada vivalada commented Feb 4, 2025

Overview/Summary

Fixing a Portal UI bug that, in the Azure Connectivity tab, was not allowing the selection of a VNet Gateway on a different Subscription that the one where the AVS is being deployed.

This PR fixes/adds/changes/removes

  1. Fixes a bug described on Issue AVS Landing Zone Accelerator Unable to Detect Existing Express route Gateway Within Existing Vnet When Using ALZs #340.

Breaking Changes

  1. No breaking changes

Testing Evidence

Provided in the related ADO Item.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

Copy link
Contributor

@jchancellor-ms jchancellor-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

@michielvanschaik michielvanschaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michielvanschaik michielvanschaik merged commit b9e7066 into Azure:main Feb 5, 2025
4 checks passed
@vivalada vivalada deleted the vivalada_fix-issue-340 branch February 5, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants