Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flkelly powershell greenfield #226

Merged
merged 66 commits into from
Feb 13, 2024
Merged

Conversation

fskelly
Copy link
Contributor

@fskelly fskelly commented Feb 28, 2023

Overview/Summary

PowerShell version of AVS Deployment
Json based for variables

Allows for full or staggered deployment

Breaking Changes

  1. Replace me
  2. Replace me

Testing Evidence

Tested with bugbash and improved with feedback from CSU

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@fskelly fskelly requested a review from prasad3017 February 28, 2023 14:56
@prasad3017
Copy link
Contributor

@khensler Could you please review the PR and approve for PowerShell module?

@prasad3017
Copy link
Contributor

@fskelly Is this PR still needed as you are able to push the code?

@sblair01
Copy link
Contributor

@fskelly @shaunjacob is this PR still applicable?

@vivalada
Copy link
Contributor

@fskelly is this PR still applicable?

Copy link
Contributor

@jchancellor-ms jchancellor-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed these changes and resolved the lone merge conflict. Will need to add an item to re-run testing on these changes to ensure that there aren't api or cli changes that may impact functionality since this was tested some time ago.

@jchancellor-ms jchancellor-ms merged commit 88ac17f into main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants