Buffer read/write/get/set strings. #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StormHub
force-pushed
the
Work
branch
4 times, most recently
from
c3d58d2 to
2c07145
Compare
StormHub
force-pushed
the
Work
branch
3 times, most recently
from
a5f9336 to
9f98d5d
Compare
nayato
reviewed
Mar 15, 2018
| { | ||
| // Surrogate Pair consumes 2 characters. Optimistically try to get the next character to avoid | ||
| // duplicate bounds checking with charAt. If an IndexOutOfBoundsException is thrown we will | ||
| // re-throw a more informative exception describing the problem. |
There was a problem hiding this comment.
where does this re-throwing happens?
There was a problem hiding this comment.
Well, if that happens L316 will through buffer index out of range
nayato
reviewed
Mar 15, 2018
| return writerIndex - oldWriterIndex; | ||
| } | ||
|
|
||
| public static int Utf8MaxBytes(string value) => Encoding.UTF8.GetMaxByteCount(value.Length); |
There was a problem hiding this comment.
I'm ok with it if it's internal, not public. Let's not publish APIs unrelated to a subject (Buffer mgmt here)
There was a problem hiding this comment.
I changed it to internal, in netty it is public but that is for CharSequence, not string.
Motivation: Implement commonly used string-based operations (originally Netty CharSequence) for byte buffers. Modifications: Added read/write/get/set strings methods to byte buffers. Also reduced unsafe pin/unpins for byte operations. Result: String-based operations are supported in DotNetty
nayato
approved these changes
Mar 15, 2018
| { | ||
| // Surrogate Pair consumes 2 characters. Optimistically try to get the next character to avoid | ||
| // duplicate bounds checking with charAt. If an IndexOutOfBoundsException is thrown we will | ||
| // re-throw a more informative exception describing the problem. |
|
An improvement to the API and performance. Nice work @StormHub! 👍 |
maksimkim
pushed a commit
to maksimkim/DotNetty
that referenced
this pull request
Sep 14, 2019
Motivation: Implement commonly used string-based operations (originally Netty CharSequence) for byte buffers. Modifications: Added read/write/get/set strings methods to byte buffers. Also reduced unsafe pin/unpins for byte operations. Result: String-based operations are supported in DotNetty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Implement commonly used string-based operations (originally Netty CharSequence) for byte buffers.
Modifications:
Added read/write/get/set strings methods to byte buffers.
Also reduced unsafe pin/unpins for byte operations.
Result:
String-based operations are supported in DotNetty