Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy for auditing Storage Accounts having configured firewall r… #481

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kimsyversen
Copy link
Contributor

It is often possible to add your ip address to the firewall on storage accounts but it is easy to forget to remove the ip address after the work is done. The result can be 100+ firewall openings over many years. Furthermore, it can be hard to easily audit and follow up and that is what this policy aim to support.

@aschabus
Copy link
Collaborator

@kimsyversen I think that the condition starting in line 45 isn't correct.
It should iterate over the parameter array one by one.
https://learn.microsoft.com/en-us/azure/governance/policy/how-to/author-policies-for-arrays

Can you please fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants