Skip to content

Created an automation to keep service tags updated. - #4332

Merged
Sreedhar Ande (sreedharande) merged 10 commits into
Azure:masterfrom
samikroy:patch-17
Nov 2, 2022
Merged

Created an automation to keep service tags updated.#4332
Sreedhar Ande (sreedharande) merged 10 commits into
Azure:masterfrom
samikroy:patch-17

Conversation

@samikroy

@samikroy Samik Roy (samikroy) commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

Created an automation to keep service tags updated.

@NikTripathi v-ntripathi (NikTripathi) added the javascript Pull requests that update Javascript code label Mar 8, 2022
@samikroy

Samik Roy (samikroy) commented Mar 8, 2022

Copy link
Copy Markdown
Contributor Author

v-ntripathi (@NikTripathi) - This automation is based on PowerShell to extract azure service tags from download center and save as a json file for further analytics to refer this.
But, tagged as JavaScript. Please let me know for any modifications.

sreedharande
Sreedhar Ande (sreedharande) suggested changes Mar 29, 2022
View reviewed changes

@sreedharande Sreedhar Ande (sreedharande) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to under tools. Add README, Steps to use it

@samikroy

Samik Roy (samikroy) commented Mar 29, 2022

Copy link
Copy Markdown
Contributor Author

Can you move this to under tools. Add README, Steps to use it

Sreedhar Ande (@sreedharande) - Thank you for sharing this, will be able to similar file here :
https://github.com/samikroy/SyncMSServiceTags/blob/main/README.md

In addition, have a question - As this is a corn job (schedule) based on devops pipeline hence moving this as a tool will make it static and we will still have old file references in the rules like - #4266

Please advise.

@v-sabiraj

v-sabiraj commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

Hey Sreedhar Ande (@sreedharande), can you please check and provide your feedback, thanks.

@samikroy

Samik Roy (samikroy) commented Apr 22, 2022

Copy link
Copy Markdown
Contributor Author

Hey Sreedhar Ande (@sreedharande), can you please check and provide your feedback, thanks.

Sreedhar Ande (@sreedharande) - Updated into tools folder as requested, please review & let me know for further updates.

@samikroy

Samik Roy (samikroy) commented May 4, 2022

Copy link
Copy Markdown
Contributor Author

Sreedhar Ande (@sreedharande) - Could you please help with merge for this.

@NikTripathi

v-ntripathi (NikTripathi) commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Sreedhar Ande (@sreedharande) Please look into this.

1 similar comment
@v-marimanda

Manoj (v-marimanda) commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

Sreedhar Ande (@sreedharande) Please look into this.

@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande)
The author Samik Roy (@samikroy) already addressed your feedback. Can you please review once again and provide your approval
Thanks

@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Sep 16, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande)
It would be great if you could review the PR and provide your feedback.
Thanks

@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Sep 20, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande)
Can you please review or route to someone who can review and provide signoff.
Thanks

@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Sep 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande)
The author Samik Roy (@samikroy) already addressed your feedback. Can you please review once again and provide your approval, so that we can merge the PR
Thanks

@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande) ,
Can you please review and approve the PR
Thanks

@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande)
Please review or assign someone to review this PR.
Thanks

@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande)
Please review or assign someone to review this PR.
Thanks

@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande)
Please review or assign someone to review this PR. Let us know if you need any other details.
Thanks

3 similar comments
@v-spadarthi

v-spadarthi commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande)
Please review or assign someone to review this PR. Let us know if you need any other details.
Thanks

@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande)
Please review or assign someone to review this PR. Let us know if you need any other details.
Thanks

@v-spadarthi

v-spadarthi commented Oct 17, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande)
Please review or assign someone to review this PR. Let us know if you need any other details.
Thanks

@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Oct 18, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande)
Please review and provide your signoff, so that we can merge this PR.
Thanks

@sreedharande

Sreedhar Ande (sreedharande) commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

Samik Roy (@samikroy) - Can you please remove .github/workflows folder. Keep your code in the parent folder. After review, we will add to workflows folder

@samikroy
Samik Roy (samikroy) requested review from a team as code owners October 20, 2022 08:38
@samikroy

Samik Roy (samikroy) commented Oct 20, 2022

Copy link
Copy Markdown
Contributor Author

Samik Roy (@samikroy) - Can you please remove .github/workflows folder. Keep your code in the parent folder. After review, we will add to workflows folder

Sreedhar Ande (@sreedharande) - Thank you for your response. Have done the changes requested, please have review & let me know.

@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande),
Author has addressed your comments. Can you please review the changes once again and provide your feedback if any.
Thanks

1 similar comment
@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Oct 28, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande),
Author has addressed your comments. Can you please review the changes once again and provide your feedback if any.
Thanks

@v-mchatla

Meena Kumari Chatla (v-mchatla) commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Hi Sreedhar Ande (@sreedharande),
It would be great if you can spare sometime on this and provide your feedback.
Thanks

@sreedharande
Sreedhar Ande (sreedharande) merged commit 6a1e980 into Azure:master Nov 2, 2022
@samikroy

Samik Roy (samikroy) commented Nov 4, 2022

Copy link
Copy Markdown
Contributor Author

Sreedhar Ande (@sreedharande) & Meena Kumari Chatla (@v-mchatla) - Thank you for the approval & merge.
As requested earlier comment,
the workflow file was moved to the parent folder and was mentioned to be moved to the workflow folder after the merge.
Could you please help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aprakash13 aprakash13 Awaiting requested review from aprakash13
@ashwin-patil Ashwin Patil (ashwin-patil) Awaiting requested review from ashwin-patil
@oshezaf Ofer Shezaf (oshezaf) Awaiting requested review from oshezaf
@petebryan Pete Bryan (petebryan) Awaiting requested review from petebryan
@preetikr Preeti Krishna (preetikr) Awaiting requested review from preetikr
@sagamzu sagamzu Awaiting requested review from sagamzu
@shainw Shain (shainw) Awaiting requested review from shainw
@thmcelro Thomas McElroy (thmcelro) Awaiting requested review from thmcelro
@YaronFruchtmann Yaron (YaronFruchtmann) Awaiting requested review from YaronFruchtmann
@oshvartz Offir Shvartz (oshvartz) Awaiting requested review from oshvartz
@ShaniFelig ShaniFelig Awaiting requested review from ShaniFelig
@laithhisham Laith Hisham (laithhisham) Awaiting requested review from laithhisham
2 more reviewers
@sreedharande Sreedhar Ande (sreedharande) sreedharande approved these changes
@v-rucdu v-rucdu v-rucdu left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@sreedharande Sreedhar Ande (sreedharande)

@v-rucdu v-rucdu

@v-mchatla Meena Kumari Chatla (v-mchatla)

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@samikroy @v-sabiraj @v-marimanda @v-mchatla @NikTripathi @v-spadarthi @sreedharande @v-rucdu