Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforcing ASim validations when failure comes #11314

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Enforcing ASim validations when failure comes #11314

merged 3 commits into from
Oct 23, 2024

Conversation

vakohl
Copy link
Contributor

@vakohl vakohl commented Oct 22, 2024

Required items, please complete

Change(s):

  • We want to fail ASim PR when any ASIM parser review test case fails

Reason for Change(s):

  • We want to fail PR when any ASIM parser review test case fails

Version Updated:

  • NA

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@vakohl vakohl requested review from a team as code owners October 22, 2024 17:17
manishkumar1991
manishkumar1991 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@manishkumar1991 manishkumar1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@v-atulyadav v-atulyadav merged commit c1cbd2f into master Oct 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishkumar1991 manishkumar1991 manishkumar1991 approved these changes

@v-atulyadav v-atulyadav v-atulyadav approved these changes

Assignees

@anki-narravula anki-narravula

@v-atulyadav v-atulyadav

Labels
ASIM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vakohl @manishkumar1991 @v-atulyadav @anki-narravula