-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPinfo Sentinel Solution New Connectors #10981
base: master
Are you sure you want to change the base?
Conversation
These are the invocation logs: WHOIS NET.csv |
Hello @AhmadMujahid2k, Thanks for raising this PR. This PR will be investigated and we will update you about the same before 29 August, 2024 |
Invocation log for new Country+ASN data connector. |
@v-prasadboke could you provide an update whether you need any changes from us (IPinfo)? I will be continuing @AhmadMujahid2k's work moving forward. Thank you! |
Hello @AhmadMujahid2k & @max-ipinfo sorry for the late response. Had some priority tasks on my name. We recommend you to upgrade the python version to 3.11 as 3.8 is deprecated and 3.9 & 3.10 will be deprecated soon |
e4cefc2
to
4ab1e11
Compare
I updated all references to Python to version 3.11: 4ab1e11 @v-prasadboke are there any other remaining steps you would like me to perform? |
@v-prasadboke could you provide an update? We are blocked on this PR to release our Solution offering to our customers. Thank you. |
Hello @AhmadMujahid2k |
@v-prasadboke regarding your error, I was trying to address your comment asking us to upgrade to Python 3.11. All I did in 4ab1e11 is changing I am unfortunately not up-to-speed with how to test a Sentinel Solution:
Thanks! |
I went through the docs: I see that
That's the version set everywhere as far as I can tell:
|
|
Hello @AhmadMujahid2k, Please provide your update on the above |
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
[-] IDs Should Be Derived From ResourceIDs (125 ms)
Property: "id" must use one of the following expressions for an resourceId property: extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid