Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPinfo Sentinel Solution New Connectors #10981

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

AhmadMujahid2k
Copy link
Contributor

@AhmadMujahid2k AhmadMujahid2k commented Aug 19, 2024

Required items, please complete

Change(s):

  • Added 14 new data connectors that use logs ingestion API to ingest data into custom tables.

Reason for Change(s):

  • New data sets required.

Version Updated:

  • Yes
  • 3.0.1

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Need Help to resolve this Fail test case of arm-ttk :
    [-] IDs Should Be Derived From ResourceIDs (125 ms)
    Property: "id" must use one of the following expressions for an resourceId property: extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid
  • Same Issue face in my previous PR IPinfo Sentinel Solution #10553

@AhmadMujahid2k AhmadMujahid2k requested review from a team as code owners August 19, 2024 10:08
@v-atulyadav v-atulyadav added Connector Connector specialty review needed Solution Solution specialty review needed labels Aug 19, 2024
@AhmadMujahid2k
Copy link
Contributor Author

@v-prasadboke
Copy link
Contributor

Hello @AhmadMujahid2k, Thanks for raising this PR. This PR will be investigated and we will update you about the same before 29 August, 2024

@AhmadMujahid2k
Copy link
Contributor Author

Invocation log for new Country+ASN data connector.
Country_ASN.csv

@max-ipinfo
Copy link

max-ipinfo commented Sep 4, 2024

@v-prasadboke could you provide an update whether you need any changes from us (IPinfo)? I will be continuing @AhmadMujahid2k's work moving forward.

Thank you!

@v-prasadboke
Copy link
Contributor

@v-prasadboke could you provide an update whether you need any changes from us (IPinfo)? I will be continuing @AhmadMujahid2k's work moving forward.

Thank you!

Hello @AhmadMujahid2k & @max-ipinfo sorry for the late response. Had some priority tasks on my name.
Right now we are upgrading the Python version of Function apps to 3.11.

We recommend you to upgrade the python version to 3.11 as 3.8 is deprecated and 3.9 & 3.10 will be deprecated soon

@max-ipinfo
Copy link

I updated all references to Python to version 3.11: 4ab1e11

@v-prasadboke are there any other remaining steps you would like me to perform?

@max-ipinfo
Copy link

@v-prasadboke could you provide an update? We are blocked on this PR to release our Solution offering to our customers.

Thank you.

@v-prasadboke
Copy link
Contributor

Hello @AhmadMujahid2k

Getting following error
image

image

@max-ipinfo
Copy link

max-ipinfo commented Sep 24, 2024

@v-prasadboke regarding your error, I was trying to address your comment asking us to upgrade to Python 3.11. All I did in 4ab1e11 is changing "linuxFxVersion" from "Python|3.10" to "Python|3.11".

I am unfortunately not up-to-speed with how to test a Sentinel Solution:

  1. can you share how I can access the web interface you showed in these two last screenshots?
  2. is there developer documentation I could follow to double-check the validation of our work?
  3. do I need to regenerate zip files under Solutions/IPinfo? If so, how?

Thanks!

@max-ipinfo
Copy link

max-ipinfo commented Sep 24, 2024

I went through the docs:
https://learn.microsoft.com/en-us/azure/azure-functions/functions-app-settings#valid-linuxfxversion-values

I see that Python|3.11 is indeed supported:

$ az functionapp list-runtimes --os linux --query "[].{stack:join(' ', [runtime, version]), LinuxFxVersion:linux_fx_version, SupportedFunctionsVersions:to_string(supported_functions_versions[])}" --output table
Stack              LinuxFxVersion       SupportedFunctionsVersions
-----------------  -------------------  ----------------------------
dotnet-isolated 8  DOTNET-ISOLATED|8.0  ["4"]
dotnet-isolated 7  DOTNET-ISOLATED|7.0  ["4"]
dotnet-isolated 6  DOTNET-ISOLATED|6.0  ["4"]
dotnet 8           DOTNET|8.0           ["4"]
dotnet 6           DOTNET|6.0           ["4"]
node 20            Node|20              ["4"]
node 18            Node|18              ["4"]
python 3.11        Python|3.11          ["4"]
python 3.10        Python|3.10          ["4"]
python 3.9         Python|3.9           ["4"]
python 3.8         Python|3.8           ["4"]
python 3.7         Python|3.7           ["4"]
java 21.0          Java|21              ["4"]
java 17.0          Java|17              ["4"]
java 11.0          Java|11              ["4"]
java 8.0           Java|8               ["4"]
powershell 7.4     PowerShell|7.4       ["4"]
powershell 7.2     PowerShell|7.2       ["4"]
custom                                  ["4"]

$ az functionapp list-runtimes --os linux --query "[].{stack:join(' ', [runtime, version]), LinuxFxVersion:linux_fx_version, SupportedFunctionsVersions:to_string(supported_functions_versions[])}" --output table | grep 3.11
python 3.11        Python|3.11          ["4"]

That's the version set everywhere as far as I can tell:

ipinfo Solutions/IPinfo (IpinfoIntegration)$ rg linuxFxVersion
Data Connectors/Abuse/azuredeploy_Connector_IPinfo_Abuse_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/RWHOIS/azuredeploy_Connector_IPinfo_RWHOIS_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/WHOIS MNT/azuredeploy_Connector_IPinfo_WHOIS_MNT_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/WHOIS ORG/azuredeploy_Connector_IPinfo_WHOIS_ORG_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/Country ASN/azuredeploy_Connector_IPinfo_Country_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/Privacy Extended/azuredeploy_Connector_IPinfo_Privacy_Extended_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/Company/azuredeploy_Connector_IPinfo_Company_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/WHOIS NET/azuredeploy_Connector_IPinfo_WHOIS_NET_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/Privacy/azuredeploy_Connector_IPinfo_Privacy_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/WHOIS ASN/azuredeploy_Connector_IPinfo_WHOIS_ASN_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/WHOIS POC/azuredeploy_Connector_IPinfo_WHOIS_POC_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/RIRWHOIS/azuredeploy_Connector_IPinfo_RIRWHOIS_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/Iplocation Extended/azuredeploy_Connector_IPinfo_Iplocation_Extended_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/Carrier/azuredeploy_Connector_IPinfo_Carrier_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/Iplocation/azuredeploy_Connector_IPinfo_Iplocation_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/Domain/azuredeploy_Connector_IPinfo_Domain_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

Data Connectors/ASN/azuredeploy_Connector_IPinfo_ASN_AzureFunction.json
117:                    "linuxFxVersion": "Python|3.11"

@v-prasadboke
Copy link
Contributor

@v-prasadboke regarding your error, I was trying to address your comment asking us to upgrade to Python 3.11. All I did in 4ab1e11 is changing "linuxFxVersion" from "Python|3.10" to "Python|3.11".

I am unfortunately not up-to-speed with how to test a Sentinel Solution:

  1. can you share how I can access the web interface you showed in these two last screenshots?
  • Go to Azure portal.
  • Select deploy a custom template
  • paste the azure deploy file in the edit template section. But before this in the azure deploy file search for "website run from package" and change its value to zip of your repo
  • after deploying head towards function page and select your function app
  1. is there developer documentation I could follow to double-check the validation of our work?
  2. do I need to regenerate zip files under Solutions/IPinfo? If so, how?
  • You do not need to regenerate the zip just include all the changes in the zip

Thanks!

@v-prasadboke
Copy link
Contributor

Hello @AhmadMujahid2k, Please provide your update on the above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants