Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Architecture Center - Style Formatting #10

Merged
merged 11 commits into from
Jan 10, 2024
Merged

Azure Architecture Center - Style Formatting #10

merged 11 commits into from
Jan 10, 2024

Conversation

ckittel
Copy link
Member

@ckittel ckittel commented Jan 5, 2024

This PR is to:

  • do a usability pass to the deployment instructions and related files in the accelerator.
  • Address Azure AD -> Entra rebranding
  • Add some TODOs

sebassem
sebassem requested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@sebassem sebassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of bugs due to spacing

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ckittel and others added 3 commits January 8, 2024 08:42
@ckittel @sebassem
Apply suggestions from code review
5e399cf 
Co-authored-by: Seif Bassem <38246040+sebassem@users.noreply.github.com>
@ckittel
more codeblock cleanups
88e1c08
@ckittel
A few more codeblock formats
dabf0b2
sebassem
sebassem approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@sebassem sebassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebassem sebassem merged commit b8db67c into Azure:main Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebassem sebassem sebassem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckittel @sebassem