Skip to content

Adding support for .bicepparam and always export WhatIf results #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 25, 2023

Conversation

Jefajers
Copy link
Member

Overview/Summary

This PR fixes #816 by adding AzOps support for .bicepparam parameter files.

This PR fixes #817 by ensuring that WhatIf results are exported to OUTPUT.json at every validate run.

This PR contains dependency bumps:

  • Az.Accounts 2.12.5
  • Az.Billing 2.0.3
  • Az.Resources 6.9.1
  • PSFramework 1.8.291

This PR fixes/adds/changes/removes

  1. Changes Invoke-AzOpsPush.ps1
  2. Changes ConvertFrom-AzOpsBicepTemplate.ps1
  3. Changes Set-AzOpsWhatIfOutput.ps1
  4. Changes Strings.psd1
  5. Changes Repository.Tests.ps1
  6. Adds bicepparamtest.bicep
  7. Adds bicepparamtest.bicepparam
  8. Changes policywithuam.bicep
  9. Adds policywithuam.bicepparam

Breaking Changes

N/A

Testing Evidence

This PR adds one new automated test of .bicepparam and changes one exsiting test to also cover .bicepparam scenarios.
image

In addition to that manual tests have been performed to validate WhatIf OUTPUT.json content.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers temporarily deployed to test August 25, 2023 09:07 — with GitHub Actions Inactive
Copy link
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go green ✅

@daltondhcp daltondhcp merged commit 5f103bb into Azure:main Aug 25, 2023
@daltondhcp daltondhcp deleted the UpdateBranch branch August 25, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Always export Set-AzOpsWhatIfOutput results to json file Feature Request - Add support for bicepparam
2 participants