Skip to content

support feature flags #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 30, 2024
Merged

support feature flags #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c035f89
support feature flags
Eskibear Apr 16, 2024
6730571
Apply suggestions from code review
Eskibear Jun 5, 2024
e269596
fix default refresh interval in comments
Eskibear Jun 5, 2024
2d0c820
Merge branch 'main' of github.com:Azure/AppConfiguration-JavaScriptPr…
Eskibear Jun 11, 2024
708f759
update constants to SNAKE_CASE
Eskibear Jun 11, 2024
7f62f14
Merge branch 'main' into yanzh/fm
Eskibear Jun 11, 2024
3cd5f59
use extracted list api
Eskibear Jun 11, 2024
923c124
throw error if selectors not provided
Eskibear Jun 12, 2024
8e2de54
parse feature flag directly
Eskibear Jun 14, 2024
1182638
refactor: rename validateSelectors to getValidSelectors
Eskibear Jun 19, 2024
99f2c29
refresh APIs apply for both kv and ff
Eskibear Jun 19, 2024
dc4f553
dedup loaded feature flags among selectors
Eskibear Jun 20, 2024
c29d834
Merge branch 'main' of github.com:Azure/AppConfiguration-JavaScriptPr…
Eskibear Jun 20, 2024
6411a30
extract requestTraceOptions as private member
Eskibear Jun 24, 2024
4ec140a
list feature flags with pageEtags
Eskibear Jul 2, 2024
453dad3
update mocked client to support byPage iterator
Eskibear Jul 3, 2024
e4eedc9
handle page deletion
Eskibear Jul 3, 2024
87316f3
upgrade @azure/app-configuration to 1.6.1
Eskibear Jul 19, 2024
1499cbf
Merge branch 'main' of github.com:Azure/AppConfiguration-JavaScriptPr…
Eskibear Jul 19, 2024
0c8a4f2
add tests for pageEtag based refresh
Eskibear Jul 19, 2024
a3f068e
Merge branch 'main' of github.com:Azure/AppConfiguration-JavaScriptPr…
Eskibear Jul 29, 2024
fb56a0f
remove pageCount as service ensure etag changes on page add/delete
Eskibear Jul 29, 2024
b1cf809
reset timer on 304, maintain refresh interval gap between attempts
Eskibear Jul 29, 2024
3c12654
use empty string as placeholder when page etag is undefined, to keep …
Eskibear Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"uuid": "^9.0.1"
},
"dependencies": {
"@azure/app-configuration": "^1.6.0",
"@azure/app-configuration": "^1.6.1",
"@azure/identity": "^4.2.1",
"@azure/keyvault-secrets": "^4.7.0"
}
Expand Down
2 changes: 1 addition & 1 deletion src/AzureAppConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export type AzureAppConfiguration = {
refresh(): Promise<void>;

/**
* API to register callback listeners, which will be called only when a refresh operation successfully updates key-values.
* API to register callback listeners, which will be called only when a refresh operation successfully updates key-values or feature flags.
*
* @param listener - Callback function to be registered.
* @param thisArg - Optional. Value to use as `this` when executing callback.
Expand Down
Loading
Loading