hide private properties of AppConfigurationImpl #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E.g. try accessing private member const settings = await load(connectionString);Before: After: |
|
Will this change raise any concerns about compatibility? |
zhiyuanliang-ms
approved these changes
Jan 3, 2024
|
Should we unify the public/private method in Adapters? |
Yes. Tracked in #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #29
Previously, TS keyword
privateonly during compilation stage. In JS you can still access "private members" if you insist.This PR adopts private properties from ECMAScript, forbidding the access of private members, for JavaScript in runtime.
Code changes:
#and removeprivatepublicwhich is the default scope.