Resolve key vault secret in parallel #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
#191
This change can bring about 40% speed-up when loading 10+ secrets.
Visible change
Added
KeyVaultOptions.parallelSecretResolutionEnabled
option to allow resolving key vault secret in parallel.Usage:
About Key Vault throttling
Key Vault allows 4000 transactions in 10 seconds, per vault per region. ref
Key Vault SDK cannot be used in browser because of CORS. I have verified this. So, for the potential browser scenario of JS provider, people should not use Key Vault reference there. This significantly reduces the chance of Key Vault throttling as Key Vault reference is only valid to use in server scenario.
For potential throttling response from Key Vault, the best practice is to use the built-in retry policy configured through SecretClientOptions.
The provider supports either registering
SecretClient
instances or configuringSecretClientOptions
. refAbout cache for Key Vault secret
Secret cache is added in #175