Skip to content

Key vault secret refresh #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 67 commits into from
Jul 10, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
2720628
support startup retry and timeout
zhiyuanliang-ms Feb 17, 2025
c15cf1b
update
zhiyuanliang-ms Feb 17, 2025
15c7e54
update
zhiyuanliang-ms Feb 17, 2025
90c4159
update
zhiyuanliang-ms Feb 17, 2025
a0e6543
add testcase
zhiyuanliang-ms Feb 17, 2025
435ff08
clarify error type
zhiyuanliang-ms Feb 19, 2025
326bf46
Merge branch 'main' of https://github.com/Azure/AppConfiguration-Java…
zhiyuanliang-ms Feb 19, 2025
6a8ceb7
update
zhiyuanliang-ms Feb 19, 2025
fc1aa5b
update
zhiyuanliang-ms Feb 19, 2025
7de8a0d
update
zhiyuanliang-ms Feb 20, 2025
5d23399
fix lint
zhiyuanliang-ms Feb 20, 2025
233af51
handle keyvault error
zhiyuanliang-ms Feb 20, 2025
a0e0792
update
zhiyuanliang-ms Feb 20, 2025
9e32db4
update
zhiyuanliang-ms Feb 21, 2025
3a33738
update
zhiyuanliang-ms Feb 23, 2025
c637682
update
zhiyuanliang-ms Feb 23, 2025
f079081
add secretRefreshIntervalInMs to KeyVaultOptions
zhiyuanliang-ms Feb 23, 2025
a9bcea4
update
zhiyuanliang-ms Feb 23, 2025
00e2e6b
update
zhiyuanliang-ms Feb 23, 2025
be55e5a
Merge branch 'zhiyuanliang/startup-timeout' of https://github.com/Azu…
zhiyuanliang-ms Feb 23, 2025
1478e94
handle keyvault reference error
zhiyuanliang-ms Feb 23, 2025
d618684
Merge branch 'zhiyuanliang/startup-timeout' of https://github.com/Azu…
zhiyuanliang-ms Feb 23, 2025
9b50135
update
zhiyuanliang-ms Feb 23, 2025
9657748
Merge branch 'zhiyuanliang/startup-timeout' of https://github.com/Azu…
zhiyuanliang-ms Feb 23, 2025
190f7b1
wip
zhiyuanliang-ms Feb 23, 2025
39d9a3d
fix lint
zhiyuanliang-ms Feb 23, 2025
ddc4a50
add secret provider
zhiyuanliang-ms Feb 23, 2025
540ec3a
add testcases
zhiyuanliang-ms Feb 24, 2025
19de218
update
zhiyuanliang-ms Feb 24, 2025
3eab635
remove extra blank line
zhiyuanliang-ms Feb 24, 2025
546d66a
update
zhiyuanliang-ms Feb 24, 2025
f8b76ed
update
zhiyuanliang-ms Feb 26, 2025
7e63ad5
update
zhiyuanliang-ms Feb 26, 2025
fe9ad2f
add boot loop protection
zhiyuanliang-ms Feb 27, 2025
1a10c89
Merge branch 'zhiyuanliang/startup-timeout' of https://github.com/Azu…
zhiyuanliang-ms Feb 27, 2025
48e1147
Merge branch 'main' of https://github.com/Azure/AppConfiguration-Java…
zhiyuanliang-ms Feb 27, 2025
b19732d
update
zhiyuanliang-ms Mar 4, 2025
80108c9
Merge branch 'main' of https://github.com/Azure/AppConfiguration-Java…
zhiyuanliang-ms Mar 13, 2025
009ccd5
update
zhiyuanliang-ms Mar 13, 2025
d61aba9
update testcase
zhiyuanliang-ms Mar 13, 2025
d81f8a9
Merge branch 'zhiyuanliang/startup-timeout' of https://github.com/Azu…
zhiyuanliang-ms Mar 13, 2025
3d88c7a
Merge branch 'main' of https://github.com/Azure/AppConfiguration-Java…
zhiyuanliang-ms Apr 23, 2025
d1ad647
Merge branch 'zhiyuanliang/startup-timeout' of https://github.com/Azu…
zhiyuanliang-ms Apr 23, 2025
73a24d4
update
zhiyuanliang-ms Apr 23, 2025
3bf0ec7
Merge branch 'zhiyuanliang/startup-timeout' of https://github.com/Azu…
zhiyuanliang-ms Apr 23, 2025
2c362ce
update testcase
zhiyuanliang-ms Apr 23, 2025
4201e6c
Merge branch 'zhiyuanliang/startup-timeout' of https://github.com/Azu…
zhiyuanliang-ms Apr 23, 2025
305fb0b
Merge branch 'main' of https://github.com/Azure/AppConfiguration-Java…
zhiyuanliang-ms May 6, 2025
bb180c2
revert unintended change
zhiyuanliang-ms May 6, 2025
11b648c
update
zhiyuanliang-ms May 7, 2025
7a4b271
update testcase
zhiyuanliang-ms May 7, 2025
4389642
Merge branch 'main' of https://github.com/Azure/AppConfiguration-Java…
zhiyuanliang-ms May 7, 2025
6d8c41f
always cached secret with version
zhiyuanliang-ms May 7, 2025
e11cbd0
update
zhiyuanliang-ms May 8, 2025
c6e4423
Merge branch 'main' of https://github.com/Azure/AppConfiguration-Java…
zhiyuanliang-ms May 8, 2025
969c0dd
update error mesage
zhiyuanliang-ms May 8, 2025
16dff9f
prevent refresh secrets operation when key alue refreshed
zhiyuanliang-ms May 11, 2025
67e7e57
Merge branch 'zhiyuanliang/secret-refresh' of https://github.com/Azur…
zhiyuanliang-ms May 11, 2025
f70f491
Merge branch 'main' of https://github.com/Azure/AppConfiguration-Java…
zhiyuanliang-ms May 13, 2025
2a8df74
Merge branch 'main' of https://github.com/Azure/AppConfiguration-Java…
zhiyuanliang-ms May 14, 2025
bf3d971
refresh secrets in parallel
zhiyuanliang-ms May 14, 2025
affee1a
Merge branch 'main' of https://github.com/Azure/AppConfiguration-Java…
zhiyuanliang-ms May 14, 2025
a865bfd
update
zhiyuanliang-ms May 14, 2025
027faa2
Merge branch 'main' into zhiyuanliang/secret-refresh
zhiyuanliang-ms Jul 2, 2025
cbf3204
enforce cache expiration for versioned secret
zhiyuanliang-ms Jul 7, 2025
349d678
always clear cache
zhiyuanliang-ms Jul 8, 2025
e8dd7f8
update
zhiyuanliang-ms Jul 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
zhiyuanliang-ms committed May 7, 2025
commit 11b648cf68d90e84654af3e3aef0a2db2e34bc6c
2 changes: 1 addition & 1 deletion src/AzureAppConfigurationImpl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
*/
async refresh(): Promise<void> {
if (!this.#refreshEnabled && !this.#featureFlagRefreshEnabled && !this.#secretRefreshEnabled) {
throw new InvalidOperationError("Refresh is not enabled for key-values, key vault secrets or feature flags.");
throw new InvalidOperationError("Refresh is not enabled for key-values, feature flags or Key Vault secrets.");
}

if (this.#refreshInProgress) {
Expand Down
2 changes: 1 addition & 1 deletion src/IKeyValueAdapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ export interface IKeyValueAdapter {
/**
* This method is called when a change is detected in the configuration setting.
*/
onChangeDetected(setting?: ConfigurationSetting): void;
onChangeDetected(setting?: ConfigurationSetting): Promise<void>;
}
Loading