-
Notifications
You must be signed in to change notification settings - Fork 2
Support load snapshot #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
zhiyuanliang/register-all-refresh
to
preview
December 19, 2024 05:51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/AzureAppConfigurationImpl.ts:946
- Ensure that the logic for handling snapshot selectors, including the error conditions, is covered by tests.
if (selector.snapshotName) {
bc3cdae
to
1f41e0d
Compare
…avaScriptProvider into zhiyuanliang/select-snapshot
Merge main to preview
…avaScriptProvider into zhiyuanliang/select-snapshot
…re/AppConfiguration-JavaScriptProvider into zhiyuanliang/select-snapshot
…ScriptProvider into zhiyuanliang/select-snapshot
…ScriptProvider into zhiyuanliang/select-snapshot
the impl looks good to me. Should we add or update our test cases to cover snapshot? |
@juniwang Do you mean add more testcases? |
yes |
…ScriptProvider into zhiyuanliang/select-snapshot
juniwang
approved these changes
May 20, 2025
RichardChen820
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API:
Allow to use snapshot selector to load key value or feature flags
Note, for expilicity, if a snapshot contains feature flag, the feature flags will only be loaded when the snapshot is used for
featureFlagOptions.selectors
This implementation is the same as kubernetes provider ref and ref