-
Notifications
You must be signed in to change notification settings - Fork 38
Merge main to release/stable/v6 for 6.1.0 stable release #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#415) * consolidate buddy pipeline yml, add release * fix spacing * restart pipelines * Trigger Build
…sh retries fail (#440) * fix caught exceptions to include aggregate with operationcanceledexception and requestfailedexception * catch aggregateexception when it contains operationcanceled too * add other checks for operationcanceled * add test for aggregate with operation canceled * remove extra space * add null check for isfailoverable * update catch order and logic, account for other exceptions besides rfe in helper methods * remove unnecessary null check * copy catch logic from tryrefreshasync to initializeasync, catch aggregateexception last in executefailoverpolicyasync * simplify isfailoverable * fix indentation on catch logic
…eshAsync (#432) * first draft using executioncontext.suppressflow to prevent httpcontext use in tryrefreshasync * working draft for suppressflow * add to functions worker as well * fix http 500 error * add comment explaining suppressflow change * fix refreshmiddleware tests to wait for TryRefreshAsync calls * remove extra space in test * use explicit type for flowControl * add delay between calling any refresh logic * ensure no more than 1 access to refresh logic per second * simplify code * update revisions * add comment to functions worker
* change testhelpers endpoints to restricted endpoint to fix test failures * remove mocktransport unused
…th wildcard match. (#441) * Update summary to explain comma separated values are not supported with wildcard match. * Update AzureAppConfigurationOptions.cs --------- Co-authored-by: Amer Jusupovic <32405726+amerjusupovic@users.noreply.github.com>
* first draft of environment variable to disable provider * move env variable to constants file * change type of string in constants * Trigger Build * add disable provider variable test * Trigger Build * Trigger Build * Trigger Build * catch securityexception * use bool.TryParse to get environment variable value, still need to find way to prevent unit test from affecting others * remove test * simplify parse env variable logic, revisions * no-op for addazureappconfiguration and useazureappconfiguration when provider disabled * add private variable to azureappconfigurationextensions, use emptyrefresherprovider in useazureappconfiguration * rename to emptyconfigurationrefresherprovider, check for refreshers length to add middleware * change emptyconfigrefreshprovider back to internal * PR revisions * fix null refreshers logic * change exception message in aspnetcore to match functionsworker
* first draft of failover log * log whenever endpoint has changed after initial call, draft * make message wording clearer * add unit test * add logic to check if endpoint has changed, fix test * remove unused using in loghelper * log for every endpoint retry * add log when all endpoints failed, remove unnecessary failed boolean * check for all endpoints failed message in tests * change message to last endpoint failed * remove spaces * fix period on message * format message again * reuse previousendpoint * change log method and constants, move logging to end of while loop * add null checks for endpoints in loghelper * null checks in provider code
avanigupta
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! This would be a merge commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.