AzureAppConfigurationHealthCheck does not honor failureStatus parameter

[isak1080]

I register my app config health checks like so:

builder.Services.AddHealthChecks()
               .AddAzureAppConfiguration(
                    name: "AzureAppConfiguration",
                    failureStatus: HealthStatus.Degraded)
              // and a few more health checks here...

What I want to achieve is that the overall status of my API is marked as Degraded when azure app config is not available since my app can function without it.

This failureStatus parameter is ignored by the AzureAppConfigurationHealthCheck implementation.

I think the solution is that instead of directly returning HealthStatus.Unhealthy, the checker should return whatever value it got from its HealthCheckContext

[zhiyuanliang-ms]

Hey, @isak1080 Thanks for reporting this issue!

This is my oversight. When I implementing the health check feature for this library, I refered to the Azure Key Vault health check implementation

But the correct way should be what you suggested. I plan to refer to the example from the MS learn doc.

Fixed in #714

[jimmyca15]

This fix was released in 8.5.0