Skip to content

Check ETag on 200 response when checking if configuration setting has changed #588

Closed
2 of 2 issues completed
@amerjusupovic

Description

@amerjusupovic

Currently, if the provider makes a request to get configuration settings using the If-None-Match header, it considers any response with a status code of 200 to mean that the queried settings have changed in the App Configuration store. However, HTTP caching rules state that if a request gets 304 but the cache has a corresponding value, it will return a 200 status code instead. This means that we would be unnecessarily refreshing the configuration in that case, which could be prevented by always checking the ETag to see if anything has changed instead of only the status code.

Sub-issues

Metadata

Metadata

Labels

enhancementNew feature or request

Type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions