Copy over sig_config code to AgentBaker. #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriksywu
reviewed
Jul 14, 2021
pkg/agent/datamodel/sig_config.go
Outdated
| // GetCloudTargetEnv determines and returns whether the region is a sovereign cloud which | ||
| // have their own data compliance regulations (China/Germany/USGov) or standard | ||
| // Azure public cloud or air gapped clouds | ||
| // NOTE(tonyxu) |
There was a problem hiding this comment.
should we remove some of these comments here
There was a problem hiding this comment.
Yeah, sure. I removed those comments.
eriksywu
approved these changes
Jul 14, 2021
yizhang4321
added a commit
that referenced
this pull request
Jul 14, 2021
* Copy over sig_config code to AgentBaker. * Remove some code comments.
AbelHu
pushed a commit
that referenced
this pull request
Jul 15, 2021
* Copy over sig_config code to AgentBaker. * Remove some code comments.
AbelHu
pushed a commit
that referenced
this pull request
Jul 15, 2021
* Copy over sig_config code to AgentBaker. * Remove some code comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.