Add an AgentBaker interface for RP to use. #926
Conversation
This is the preparation step to separate AgentBaker into a standalone service. RP will call the API provided by AgentBaker to get CustomData, CSE, and VHD image to provision nodes. We'll use protocol buffer and gRPC for the API definition. For now, use straight Go interface as API to help testing the end to end flow.
| "github.com/Azure/agentbaker/pkg/agent/datamodel" | ||
| ) | ||
|
|
||
| type AgentBaker interface { |
There was a problem hiding this comment.
does the agentbaker pkg itself need to define the interface contract that it implements? In go it's more common to define the interface at the consuming pkg (i.e our backend rp code)
There was a problem hiding this comment.
In our code base, do we have an example with interface being defined at the consuming side? I saw more examples with interfaces defined at the library code. For example, our core/clients defined all the interfaces. Another example is the Azure SDK for Go library we use: it defines the interfaces: https://github.com/Azure/azure-sdk-for-go/blob/main/services/compute/mgmt/2021-03-01/compute/computeapi/interfaces.go
| } | ||
| } | ||
|
|
||
| return nodeBootstrapping, nil |
There was a problem hiding this comment.
do we need to return an error if the input distro doesn't have a corresponding AzureCloudOSImage?
There was a problem hiding this comment.
actually do we need to move SIG configs here as well? Will that be done in a separate PR?
There was a problem hiding this comment.
I changed the code to return an error when cloud is not found.
Not returning an error if image is not found yet because for some cases the image is only found in SIG.
I'll prepare a new PR to move over the SIG settings. When that is done, if the image is not found in both places, I'll make the function return an error.
pkg/agent/datamodel/osimageconfig.go
Outdated
| ImageVersion: "latest", | ||
| } | ||
|
|
||
| CoreOSImageConfig = AzureOSImageConfig{ |
There was a problem hiding this comment.
I doubt this os config is used at all
There was a problem hiding this comment.
Yeah, you are right. I just copied the whole thing. CoreOS has been removed now.
* Add an AgentBaker interface for RP to use. This is the preparation step to separate AgentBaker into a standalone service. RP will call the API provided by AgentBaker to get CustomData, CSE, and VHD image to provision nodes. We'll use protocol buffer and gRPC for the API definition. For now, use straight Go interface as API to help testing the end to end flow. * Return error if cloud is not found in the OS image settings. * Remove setting for CoreOS. It's not used.
This is the preparation step to separate AgentBaker into a standalone service. RP will call the API provided by AgentBaker to get CustomData, CSE, and VHD image to provision nodes.
We'll use protocol buffer and gRPC for the API definition. For now, use straight Go interface as API to help testing the end to end flow.