Remove unused fields from type "AgentPoolProfile". #914
Conversation
| CustomKubeletConfig *CustomKubeletConfig `json:"customKubeletConfig,omitempty"` | ||
| CustomLinuxOSConfig *CustomLinuxOSConfig `json:"customLinuxOSConfig,omitempty"` | ||
| Name string `json:"name"` | ||
| Count int `json:"count"` |
There was a problem hiding this comment.
question: for this PR, we are only removing parameters that are not populated in paramsMap - correct?
I could be wrong but I think Count is one of those that get written to the map but aren't actually used anywhere.
There was a problem hiding this comment.
Thanks for the info. Yeah, you are right, this PR only removes the easy, obvious ones. Once this goes in, I'll look into "Count". If as you mentioned it is not used, I'll remove it.
| CustomNodeLabels map[string]string `json:"customNodeLabels,omitempty"` | ||
| PreprovisionExtension *Extension `json:"preProvisionExtension"` | ||
| KubernetesConfig *KubernetesConfig `json:"kubernetesConfig,omitempty"` | ||
| AvailabilityZones []string `json:"availabilityZones,omitempty"` |
There was a problem hiding this comment.
I don't think we're using this anywhere are we?
There was a problem hiding this comment.
Thanks for the info. I will go through them and remove unused ones in future PRs.
| "name": "nodepool1", | ||
| "orchestratorVersion": "1.19.3", |
There was a problem hiding this comment.
Just to clarify, are we removing agentPoolProfile.orchestratorVersion because we have the same field as properties. orchestratorProfile.orchestratorVersion already present?
There was a problem hiding this comment.
The orchestratorVersion version in AgentPoolProfile is never used in AgentBaker, thus I removed it.
No description provided.