fix: remove hardcode MAR endpoint in ensurePodInfraContainerImage for Network isolated cluster#8735
Open
fseldow wants to merge 5 commits into
Open
fix: remove hardcode MAR endpoint in ensurePodInfraContainerImage for Network isolated cluster#8735fseldow wants to merge 5 commits into
fseldow wants to merge 5 commits into
Conversation
fseldow
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
runzhen,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the hardcoded mcr.microsoft.com registry base when rewriting the pause (pod infra) image for network-isolated clusters, making the replacement respect the configured MCR base for both Windows and Linux provisioning paths.
Changes:
- Windows: update
Set-PodInfraContainerImageto replace usingMCRRepositoryBase(trimmed) instead of a hardcodedmcr.microsoft.com. - Windows: add Pester coverage for
MCRRepositoryBaseset/unset/trailing-slash cases. - Linux: update
ensurePodInfraContainerImageto replace usingMCR_REPOSITORY_BASE(trimmed) with ShellSpec coverage for the same cases.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| staging/cse/windows/networkisolatedclusterfunc.ps1 | Uses MCRRepositoryBase (trimmed) as the replacement source registry base when rewriting the pause image. |
| staging/cse/windows/networkisolatedclusterfunc.tests.ps1 | Adds Pester tests validating pause image rewrite behavior with custom MCR base, default fallback, and trailing slash handling. |
| parts/linux/cloud-init/artifacts/cse_config.sh | Uses MCR_REPOSITORY_BASE (trimmed, with default) instead of hardcoded mcr.microsoft.com for pause image rewrite. |
| spec/parts/linux/cloud-init/artifacts/cse_config_spec.sh | Adds ShellSpec tests validating MCR_REPOSITORY_BASE behavior (set/unset/trailing slash) for pause image rewrite. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
fseldow
changed the title
awesomenix
approved these changes
Jun 18, 2026
djsly
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove hardcode of MAR endpoint in ensurePodInfra (only implemented in network isolated cluster)
Which issue(s) this PR fixes:
Fixes #