chore(vhdbuilder): switch ACL VHD builds to SIG source from acldevel …#8734
Draft
mayankfz wants to merge 1 commit into
Draft
chore(vhdbuilder): switch ACL VHD builds to SIG source from acldevel …#8734mayankfz wants to merge 1 commit into
mayankfz wants to merge 1 commit into
Conversation
…gallery
Switch ACL and ACL ARM64 Packer templates from marketplace images back to
direct shared gallery source (acldevel/acl-grub, acldevel/acl-grub-arm64).
Parameterize gallery, image definition, and version so they can be overridden
at pipeline trigger time (for daily ACL validation from mariner-org/ACL).
- Packer: vhd-image-builder-acl{,-arm64}.json use shared_image_gallery.direct_shared_gallery_image_id
- Release pipeline: new params aclSigSourceGallery, aclSigSourceImageName, aclSigSourceArm64ImageName, aclImageVersion, aclArm64ImageVersion
- PR builder: hardcoded to acldevel gallery with 0.20260523.1124361
- spec: updated ensure_sig_image_name_linux tests for SIG source (no IMG_OFFER)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ACL (Azure Container Linux) VHD build flow to source base images from a directly shared SIG instead of marketplace images, and makes the SIG source configurable for release pipeline runs.
Changes:
- Switch
vhd-image-builder-acl{,-arm64}.jsonto useshared_image_gallery.direct_shared_gallery_image_idbuilt fromSIG_SOURCE_*environment variables. - Update PR and release pipelines to set (and for release: parameterize)
SIG_SOURCE_GALLERY_UNIQUE_NAME,SIG_SOURCE_IMAGE_NAME, andSIG_SOURCE_IMAGE_VERSIONfor ACL builds. - Adjust ShellSpec coverage for
ensure_sig_image_name_linuxso ACL scenarios no longer rely onIMG_OFFER.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vhdbuilder/packer/vhd-image-builder-acl.json | Replace marketplace image source fields with direct shared gallery source for ACL (amd64). |
| vhdbuilder/packer/vhd-image-builder-acl-arm64.json | Replace marketplace image source fields with direct shared gallery source for ACL (arm64). |
| spec/vhdbuilder/packer/ensure_sig_image_name_linux_spec.sh | Update ACL-related tests to reflect that ACL builds no longer set/use IMG_OFFER. |
| .pipelines/.vsts-vhd-builder.yaml | Update PR builder ACL jobs to set SIG_SOURCE_* variables instead of IMG_*. |
| .pipelines/.vsts-vhd-builder-release.yaml | Add release parameters for ACL SIG source and wire them into ACL job variable setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…gallery
Switch ACL and ACL ARM64 Packer templates from marketplace images back to direct shared gallery source (acldevel/acl-grub, acldevel/acl-grub-arm64).
Parameterize gallery, image definition, and version so they can be overridden at pipeline trigger time (for daily ACL validation from mariner-org/ACL).
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #