fix: update kube-proxy to 1.33.6 #7834
Conversation
Devinwong
requested review from
AbelHu,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
github-actions
bot
added
the
components
There was a problem hiding this comment.
Pull request overview
This PR updates the Kubernetes kube-proxy image tag used by the build/provisioning system and changes Azure DevOps E2E pipeline behavior to be non-blocking.
Changes:
- Bump
mcr.microsoft.com/oss/kubernetes/kube-proxy(v1.33 track) fromv1.33.5-hotfix.20250926tov1.33.6inparts/common/components.json. - Make the shared
.pipelines/templates/e2e-template.yamlE2E jobcontinueOnError: true(i.e., E2E failures no longer fail the job).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| parts/common/components.json | Updates kube-proxy image version used by builds (v1.33.x). |
| .pipelines/templates/e2e-template.yaml | Makes the shared E2E job non-blocking via continueOnError. |
| - job: e2e | ||
| continueOnError: true | ||
| condition: and(succeeded(), ne(variables.SKIP_E2E_TESTS, 'true')) |
There was a problem hiding this comment.
continueOnError: true on the e2e job makes all pipelines that consume this shared template treat E2E failures as non-fatal (Linux PR/release pipelines and GPU E2E included), not just Windows. If the intent is to make only Windows E2E optional, consider adding a template parameter (default false) or using a dedicated windows-only template, and set continueOnError only from .pipelines/e2e-windows.yaml / windows build pipelines.
This reverts commit 679d968.
| - job: e2e | ||
| continueOnError: ${{parameters.continueOnError}} | ||
| condition: and(succeeded(), ne(variables.SKIP_E2E_TESTS, 'true')) |
There was a problem hiding this comment.
Setting continueOnError makes the job non-blocking, but the job will still show as failing in the UI (just not fail the stage). If the intent is to make the outcome explicitly visible as a warning/optional signal, consider also documenting this behavior in the template (e.g., a short comment near the parameter) so consumers understand the semantics and don’t assume the job becomes 'successful'.
Devinwong
changed the title
4 participants
update kube-proxy to 1.33.6
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #