Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat. add check to enable disabling secure boot for windows nodes #3678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juliusl
Copy link
Member

@juliusl juliusl commented Oct 5, 2023

  • For testing drivers w/ windows secure boot must be disabled

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds an env var check in windows/e2e-scenario.sh in order to disable secure boot. In order to test unsigned Windows Drivers secure boot must be disabled.

  • Windows Org locks down being able to create signed drivers, meaning to evaluate and test windows drivers secure boot must be disabled so that installing unsigned drivers can be setup.

Which issue(s) this PR fixes:

Fixes #3677

Requirements:

Special notes for your reviewer:

Release note:

none

@juliusl juliusl temporarily deployed to test October 5, 2023 23:36 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 5, 2023

Pull Request Test Coverage Report for Build 9586893073

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.969%

Totals Coverage Status
Change from base Build 9586608818: 0.0%
Covered Lines: 2627
Relevant Lines: 3458

💛 - Coveralls

@AbelHu
Copy link
Member

AbelHu commented Oct 7, 2023

@juliusl Thanks for the PR. Do you only want to disable secure boot for Windows nodes in AgentBaker e2e tests? If so, your PR looks good.

  1. One required test failed because the PR/commit message does not follow the commit message lint. You need to update feat. to feat:
  2. E2E tests only can be run when you create the PR from a branch in Azure/AgentBaker but not a forked repo. You can ping me in teams so I can guide you how to request the permission.

- For testing drivers w/ windows secure boot must be disabled
@juliusl
Copy link
Member Author

juliusl commented Jun 19, 2024

@juliusl Thanks for the PR. Do you only want to disable secure boot for Windows nodes in AgentBaker e2e tests? If so, your PR looks good.

@AbelHu Finally getting back around to this, yes I only want to be able to do this in e2e tests

Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the suggestions in teams to create new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option in e2e testing to allow secure boot to be disabled for windows
3 participants