-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat. add check to enable disabling secure boot for windows nodes #3678
Open
juliusl
wants to merge
1
commit into
Azure:master
Choose a base branch
from
juliusl:pr/e2e-testing-disable-secure-boot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9586893073Details
💛 - Coveralls |
@juliusl Thanks for the PR. Do you only want to disable secure boot for Windows nodes in AgentBaker e2e tests? If so, your PR looks good.
|
- For testing drivers w/ windows secure boot must be disabled
juliusl
force-pushed
the
pr/e2e-testing-disable-secure-boot
branch
from
June 19, 2024 18:51
122014f
to
f5e744f
Compare
juliusl
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
jason1028kr and
djsly
as code owners
June 19, 2024 18:51
AbelHu
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the suggestions in teams to create new PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds an env var check in windows/e2e-scenario.sh in order to disable secure boot. In order to test unsigned Windows Drivers secure boot must be disabled.
Which issue(s) this PR fixes:
Fixes #3677
Requirements:
Special notes for your reviewer:
Release note: