fix: Add -v flag to curl calls passed to timeout. #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If curl hangs for unknown reason, timeout will stop the command after specified timeout and no logs will be printed out, making it hard to pinpoint what exactly stopped curl from completing.
UtheMan
requested review from
alexeldeib,
juan-lee,
AbelHu and
thomas1206
as code owners
cameronmeissner
approved these changes
Mar 24, 2023
Pull Request Test Coverage Report for Build 4547024836
💛 - Coveralls |
cameronmeissner
approved these changes
Mar 28, 2023
alexeldeib
approved these changes
Mar 28, 2023
juan-lee
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If curl hangs for unknown reason, timeout will stop the command after specified timeout and no logs will be printed out, making it hard to pinpoint what exactly stopped curl from completing.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: