Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binaries for 1.23.15, 1.24.9, 1.25.5 k8s version. #2559

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

yizhang4321
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add binaries for 1.23.15, 1.24.9, 1.25.5 k8s version.

Requirements:

Special notes for your reviewer:

Release note:

none

@yizhang4321 yizhang4321 temporarily deployed to test January 10, 2023 18:42 — with GitHub Actions Inactive
Copy link
Member

@AbelHu AbelHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rerun those failed tests and I think that the failures are not caused by this PR.

@yizhang4321 yizhang4321 merged commit 270f27c into master Jan 11, 2023
@yizhang4321 yizhang4321 deleted the yizhang5/2023JanK8sPatch branch January 11, 2023 01:08
@@ -12,13 +12,16 @@
"1.23.12-hotfix.20221109.2",
"1.23.8-hotfix.20221109.1",
"1.23.8-hotfix.20221109.2",
"1.23.15",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kube-proxy for k8s 1.23 patch versions, needs to use the hotfix version (after creating separate build)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious: 1.23.15 is the latest patch version for v1.23. why do we still need to hotfix it? https://github.com/kubernetes/kubernetes/releases

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because this feature is needed (Detect local traffic using interface): kubernetes/kubernetes#95400, in k8s 1.23 on AKS as well (upstream has it merged for k8s 1.24+).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New PR here: #2574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants