k8s binary versions - move to manifest.cue and reduce repetition in build test #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshkumarashok
changed the title
cameronmeissner
approved these changes
Oct 27, 2022
alexeldeib
reviewed
Oct 27, 2022
alexeldeib
reviewed
Oct 27, 2022
alexeldeib
reviewed
Oct 27, 2022
…r/k8sbinaries_json
alexeldeib
reviewed
Oct 27, 2022
alexeldeib
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it:
Needed for:
This moves k8s binary versions from two bash scripts (install-dependencies.sh and linux-vhd-content-test.sh), to a single config file (manifest.cue).
Reducing repetition of versions makes k8s versioning faster and moving the versions to a config file, provides a way to automate k8s versioning (and also splitting k8s versions amongst VHDs).
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: