Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set DisableAcceleratorUsageMetrics to false for 1.25.0 and above. #2176

Conversation

yizhang4321
Copy link
Member

Otherwise, will get error like:
cannot set feature gate DisableAcceleratorUsageMetrics to false, feature is locked to true

What type of PR is this?
Bug fix

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

Otherwise, will get error like:
    cannot set feature gate DisableAcceleratorUsageMetrics to false, feature is locked to true
@yizhang4321 yizhang4321 temporarily deployed to test September 12, 2022 04:50 Inactive
Copy link
Contributor

@ganeshkumarashok ganeshkumarashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR needs to be made from a branch in Azure/Agentbaker, instead of a fork, for all the tests to run

pkg/agent/baker.go Outdated Show resolved Hide resolved
@yizhang4321 yizhang4321 temporarily deployed to test September 13, 2022 06:53 Inactive
@yizhang4321 yizhang4321 merged commit 6fb80e5 into Azure:master Sep 13, 2022
@yizhang4321 yizhang4321 deleted the yizhang4321/DisableAcceleratorUsageMetrics branch September 13, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants