Containerd 1.6.4 for k8s >= 1.24 #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…>= 1.23 in cse_install
ganeshkumarashok
changed the title
ganeshkumarashok
changed the title
alexeldeib
reviewed
May 19, 2022
| else | ||
| echo "WARNING: containerd version not found in manifest, defaulting to hardcoded." | ||
| fi | ||
|
|
||
| # todo(ace): read 1.22 from a manifest and track it against supported versions | ||
| if semverCompare ${KUBERNETES_VERSION} "1.22.0"; then | ||
| if semverCompare ${KUBERNETES_VERSION} "1.24.0"; then |
There was a problem hiding this comment.
would be nice if we can figure out a way to structure this so we can just enumerate (k8s version, containerd version) tuples and compare against desired version instead of branching this case more.
in practice we probably only have a few
There was a problem hiding this comment.
yeah, that would be nice. So we can avoid having all these cases.
alexeldeib
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containerd 1.6.4 works with k8s 1.24, in the standalone environment!