Skip to content

bug: fix switch and os selector #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Oct 2, 2023

Pull Request

Issue

Issue #, if available: #71, #73, and #74

Description

Description of changes: Fix issues with downloading the HCL parser and running it on MacOS and Linux. Also solve a potential issue where Terraform runs despite bicep being selected.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

@jaredfholgate jaredfholgate changed the title bu: fix switch and os selector bug: fix switch and os selector Oct 2, 2023
@jaredfholgate
Copy link
Member Author

@matt-FFFFFF and @oZakari There is limited testing I can do on this due to lacking a Mac, but I have tested in Linux and works as expected. However in my environment the file is already set as executable when it downloads, so unsure if my testing is valid.

I wish there was a PowerShell native HCL parser, but only libraries I can find are golang. I could write something bespoke, but was trying to avoid that. I also want to avoid storing binaries in source control. We might need to publish this for Matt to test it properly, sorry. I will also try to find someone with a Mac once it is published.

@matt-FFFFFF
Copy link
Member

@jaredfholgate I have a Mac! We can also run GH actions using macOS runners.

Thank you for the speedy response here.

Hth tomorrow

@jaredfholgate
Copy link
Member Author

@jaredfholgate I have a Mac! We can also run GH actions using macOS runners.

Thank you for the speedy response here.

Hth tomorrow

@matt-FFFFFF and @oZakari I am going look at writing some cross OS pester tests and an associated action for that particular function later today. If it is urgent you can merge this PR today and will add them to a separate one.

@matt-FFFFFF
Copy link
Member

Hi @jaredfholgate @oZakari

Confirmed this branch is working on WSL:

image

Checking MacOS now

@matt-FFFFFF
Copy link
Member

Hi @jaredfholgate and @oZakari

Confirmed working on MacOS

image

Please can we merge this? I was hoping to use it for a conference demo next week!

@jtracey93 jtracey93 merged commit 8ed310d into main Oct 3, 2023
@jtracey93 jtracey93 deleted the bug-fix-switch-and-os-selector branch October 3, 2023 10:59
@jtracey93
Copy link
Collaborator

@matt-FFFFFF merged and new release will be out shortly of the module, please update it locally in about 30 mins :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants