Correct parameters for copy file #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Write-InformationColored "Copying ALZ-Bicep module to $alzEnvironmentDestinationInternalCode" -ForegroundColor Green -InformationAction Continue | ||
| Copy-ALZParametersFile -alzEnvironmentDestination $alzEnvironmentDestination -upstreamReleaseDirectory $(Join-Path $alzEnvironmentDestinationInternalCode $bicepConfig.version) -configFiles $bicepConfig.config_files | Out-String | Write-Verbose |
There was a problem hiding this comment.
Write-Verbose - is absolute genius.
| return $true | ||
| } | ||
| $gitInit = Read-Host "Initialize the directory $alzEnvironmentDestination as a git repository? (y/n)" | ||
| if (($gitInit -eq "y" -or $gitInit -eq "Y") -and $PSCmdlet.ShouldProcess("gitrepository", "initialize")) { |
There was a problem hiding this comment.
This got me thinking about Powershell case sensitivity:
https://stackoverflow.com/questions/64127557/powershell-if-eq-and-ieq-are-case-in-sensitive-and-serves-same-purpose-or-ieq
Apparently we can use -ieq, but the answer here says that it's just an alias for -eq and is case insensitive anyway.
lovelysandwich
approved these changes
Mar 21, 2023
Co-authored-by: Guy Pritchard MSFT <111762521+lovelysandwich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct the parameters file so we can copyu the destination files.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.