Skip to content

feat: improvements to inputs and region validation #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 6, 2024
Merged

feat: improvements to inputs and region validation #182

merged 11 commits into from
Sep 6, 2024

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Sep 5, 2024 •
edited
Loading

Pull Request

Issues

#124

Description

This PR adds a few improvements:

  • The regions and availability zones are now retrieved dynamically.
  • The PowerShell module supports overriding the bootstrap terraform.tfvars file as one method of supplying values for hidden variables.
  • The PowerShell module supports supplying hidden bootstrap variables via the inputs config file, for example resource names can now be supplied there.
  • The override.tfvars file is now in json format, so we can support complex data types.

e2e test run: https://github.com/Azure/accelerator-bootstrap-modules/actions/runs/10734976021

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

@jaredfholgate jaredfholgate changed the title Improvements feature: improvements to inputs and region validation Sep 5, 2024
@jaredfholgate jaredfholgate changed the title feature: improvements to inputs and region validation feat: improvements to inputs and region validation Sep 5, 2024
@jaredfholgate jaredfholgate self-assigned this Sep 5, 2024
@jaredfholgate jaredfholgate marked this pull request as ready for review September 5, 2024 20:15
oZakari
oZakari reviewed Sep 5, 2024
View reviewed changes
@oZakari oZakari added Type: Documentation 📄 Improvements or additions to documentation Area: Terraform Accelerator 👽 Issues / PR's related to Terraform Accelerator labels Sep 5, 2024
@jaredfholgate
Copy link
Member Author

Started new e2e test run: https://github.com/Azure/accelerator-bootstrap-modules/actions/runs/10734976021

oZakari
oZakari approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@oZakari oZakari merged commit aa0f60e into main Sep 6, 2024
5 checks passed
@oZakari oZakari deleted the feature-multi-region-support branch September 6, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oZakari oZakari oZakari approved these changes

Assignees

@jaredfholgate jaredfholgate

Labels
Area: Terraform Accelerator 👽 Issues / PR's related to Terraform Accelerator Type: Documentation 📄 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredfholgate @oZakari