Skip to content

fix: Remove unneeded policies #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix: Remove unneeded policies #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 0 additions & 55 deletions .github/policies/resourceManagement.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,61 +205,6 @@ configuration:
then:
- cleanEmailReply
description:
- if:
- payloadType: Pull_Request
- isAction:
action: Opened
- or:
- includesModifiedFiles:
files:
- infra-as-code/bicep/modules/policy/definitions/lib
- includesModifiedFiles:
files:
- infra-as-code/bicep/modules/policy/assignments/lib/policy_assignments
then:
- addReply:
reply: >-
Hey ${issueAuthor}, thanks for creating this PR.


We noticed that this PR is ammending some things related to policies (definitions or assignments) :mag:


Thanks for this however, please keep in mind we replicate all policies from our upstream repo https://github.com/Azure/Enterprise-Scale (via some GitHub Actions) into these Bicep modules.


So it may be that this PR may be closed and we ask you to re-submit the changes to the respective code in our other repo.


However, we will review and advise further anyway but this is just a friendly premptive message and reminder of how policies are used and updated in this repo.


Thanks from your friendly msft-bot.
- addLabel:
label: "Area: Policy"
description:
- if:
- payloadType: Pull_Request
- labelAdded:
label: "Needs: Upstream Policy Changes :arrows_clockwise:"
then:
- addReply:
reply: >-
Hey ${issueAuthor}, thanks for creating this PR.


We noticed that this PR is ammending some things related to policies (definitions or assignments) :mag:


Thanks for this however, please keep in mind we replicate all policies from our upstream repo https://github.com/Azure/Enterprise-Scale (via some GitHub Actions) into these Bicep modules.


We have determined, upon our review, that the changes here are required to be made to the upstream policies in the repo: https://github.com/Azure/Enterprise-Scale


Thanks from the team and our friendly msft-bot.
- closeIssue
description:
- if:
- payloadType: Pull_Request
- hasLabel:
Expand Down
Loading