Skip to content

Fixing nested replacement #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 27, 2023
Merged

Fixing nested replacement #17

merged 9 commits into from
Mar 27, 2023

Conversation

lovelysandwich
Copy link
Contributor

@lovelysandwich lovelysandwich commented Mar 23, 2023

Pull Request

A number of things being worked on in here...

  1. Handling nested configuration items. Be they objects or arrays of objects.
  2. Some fix ups based on feedback.

Issue

Issue #, if available:

#13
#12
#6
#18

License

By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.

@lovelysandwich lovelysandwich marked this pull request as ready for review March 24, 2023 14:59
Copy link
Member

@Nepomuceno Nepomuceno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some few comments

@lovelysandwich lovelysandwich merged commit 27745e3 into main Mar 27, 2023
@lovelysandwich lovelysandwich deleted the fixing_nested_replacement branch March 27, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants