-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logic to load locations and VM sku's from json files #444
Conversation
@Gordonby I made an attemp to add the bash script to the build.yml process. I wasn't sure if if was correct or not. Plus, not too sure how to test it. |
This looks really good @fireblade95402 |
@fireblade95402 - i'm seeing this problem when running the script. Perhaps we need more error handling, or debug output? I'm testing from a codespace in this repo. |
@Gordonby If I run the script with "./generate-vm-sku-list-v2.sh" it works and when I run it with "sh generate-vm-sku-list-v2.sh" I get the same error you get. I'll have a look at why |
Ok, I'm using "bash" shell and not the "sh" shell. Gather differences in language support. Should we be making it "sh" or would "bash" be ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
we may want to revisit the script file to look for potential optimisation... But since it's just called once in release rather than by the UI - i think we're good.
PR Summary
This change loads the vm sku's from a json file by location that is generated by a bash script in the build.yml action. Plus, loads the locations from another locations.json file.
The genertation of toe sku's is driven from a locations.json and skuFamilies.json files, which needs to be manually updated at this point in time.
The current locations and skufamilies files are aligned to the current list from main, excluding UKSouth2, which wasn't found in the API calls to fetch the sku's.
The screen has changed to also a custom sku to be entered and sku name has been added to the dropdown
Logic has also been added to handle the 3 compute types on the screen, but the IO Optimized and GPU Workloads are disabled for now.
PR Checklist